Also transform inline mappings to objects #17079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
Isn't it for 2.7? |
|
Yes, should be merged into |
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Dec 26, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #17079). Discussion ---------- Also transform inline mappings to objects | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17075 | License | MIT | Doc PR | - `$objectForMapping` was only applied to inlined mappings. It should be applied for multi-line mappings as well. Commits ------- 61b863b Also transform inline mappings to objects
This was referenced Dec 26, 2015
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$objectForMappingwas only applied to inlined mappings. It should be applied for multi-line mappings as well.