[Yaml] mark the Inline class as internal #17740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the Dumper and Parser should probably be kept as not-internal as I find it useful to create one parser/dumper and reuse it in more than one place. But we can probably mark some public methods as internal. |
xabbuh
force-pushed
the
yaml-internal-classes
branch
from
4e76c4b
to
09a54ef
Compare
xabbuh
changed the title
|
okay, then let's only mark the |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Yaml] mark the Inline class as internal | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Users imo should use the `Yaml` class as the only entry point. Thus marking the other classes as internal makes it easier for us to break BC in them when implementing new features in Symfony 4. Commits ------- 09a54ef [Yaml] mark the Inline class as internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users imo should use the
Yamlclass as the only entry point. Thus marking the other classes as internal makes it easier for us to break BC in them when implementing new features in Symfony 4.