[Ldap] Fixed CS and hardened some code #17833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csarrazi
changed the title
|
👍 |
|
Thank you @csarrazi. |
fabpot
added a commit
that referenced
this pull request
Feb 18, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Ldap] Fixed CS and hardened some code | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16665 | License | MIT | Doc PR | no This PR takes into account remaining comments from #16665 Commits ------- eefa70d Fixed CS and hardened some code
| @@ -84,7 +85,13 @@ private function initialize() | |||
| return; | |||
| } | |||
|
|
|||
| $entries = ldap_get_entries($this->connection->getResource(), $this->search->getResource()); | |||
| $con = $this->connection->getResource(); | |||
There was a problem hiding this comment.
What if getResource() returns null (maybe I simply miss the point where we ensure that the connection is always established before this code is executed)?
There was a problem hiding this comment.
The connection is always established before this code is executed.
Either the Query class creates the connection if non-existent (with default values), or it uses the existing connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes into account remaining comments from #16665