[DependencyInjection] replace alias in factory services #17867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 20, 2016
xabbuh
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17864 |
| License | MIT |
| Doc PR |
| @@ -122,4 +124,13 @@ private function updateArgumentReferences(array $arguments, $currentId, $newId) | |||
|
|
|||
| return $arguments; | |||
| } | |||
|
|
|||
| private function updateFactoryServiceReference($factoryService, $currentId, $newId) | |||
There was a problem hiding this comment.
Why introducing a new method if it is as short and only used one time?
There was a problem hiding this comment.
I understand now, the 2.7 version has more code, so looks fine to me as it will ease merging.
There was a problem hiding this comment.
Well, we can indeed inline this for the 2.3 fix. I have no hard feelings about it.
|
Actually, 2.7 will need both this code and the code added in the other PR (as 2.7 has both the new |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 23, 2016
…abbuh) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] replace alias in factory services | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17864 | License | MIT | Doc PR | Commits ------- 56f8798 replace alias in factory services
This was referenced Feb 28, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.