[Validator] In "strict" mode, email validator inaccurately claims certain valid emails are invalid #18157
Conversation
natechicago
commented
Mar 13, 2016
natechicago
commented
| Q | A |
|---|---|
| Branch | 2.5 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | potentially |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18156 |
| License | MIT |
| Doc PR | n/a |
…tain valid emails are invalid - symfony#18156
|
Should the second argument pass the value of |
|
@patrick-mcdougle Interesting question/suggestion. In general, I'd probably recommend not including such a change in this particular PR, since it's out of scope relative to the bug this PR is trying to remedy. But even if it had its own PR, I don't think we'd gain any benefit from sending that info to the external email validation library. The MX record check performed by the external library is basically identical to the MX record check that Symfony is already well-equipped to handle in its own email validator. |
| @@ -65,7 +65,7 @@ public function validate($value, Constraint $constraint) | |||
|
|
|||
| $strictValidator = new \Egulias\EmailValidator\EmailValidator(); | |||
|
|
|||
There was a problem hiding this comment.
The intent here is to send the 3rd argument as false, rather than true. But thanks to the default values for the 2nd and 3rd arguments (false and false, respectively), they can now be omitted completely.
|
I think this should be considered as a new feature, and we should allow the user to decide which mode is appropriated, with a default to the same as today and a new |
|
Closing this PR in favor of #18428. |
