[Validator] Test DNS Email constraints using checkdnsrr() mock #18196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 16, 2016
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch | 2.3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
mock-dns
branch
from
4e86bf1
to
cf72249
Compare
nicolas-grekas
force-pushed
the
mock-dns
branch
from
cf72249
to
165755a
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Mar 16, 2016
…) mock (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Test DNS Email constraints using checkdnsrr() mock | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 165755a [Validator] Test DNS Email constraints using checkdnsrr() mock
| @@ -52,7 +52,7 @@ if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit") || md5_file(__ | |||
| $zip->close(); | |||
| chdir("phpunit-$PHPUNIT_VERSION"); | |||
| passthru("$COMPOSER remove --no-update symfony/yaml"); | |||
| passthru("$COMPOSER require --dev --no-update symfony/phpunit-bridge \">=2.8@dev\""); | |||
| passthru("$COMPOSER require --dev --no-update symfony/phpunit-bridge \">=3.1@dev\""); | |||
There was a problem hiding this comment.
is the bridge still compatible with PHP 5.3 in Symfony 3 ?
There was a problem hiding this comment.
yes, I verified before merging :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.