[VarDumper] Add Redis caster #18675
Merged
[VarDumper] Add Redis caster #18675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| class RedisCaster | ||
| { | ||
| private static $serializer = array( |
There was a problem hiding this comment.
Are you planning to add the docblocks when the PR will be ready to merge?
There was a problem hiding this comment.
Nope, I'm not planning any doc block here...
There was a problem hiding this comment.
@nicolas-grekas, that makes me wonder: which are the criteria we use to decide what to document and what to not document?
|
Can the caster be tested ? |
|
Tests added, comments addressed. |
|
This feature looks great ... but the code sometimes is not very readable because of the single-letter variable names ( |
| $redis = new \Redis(); | ||
|
|
||
| if (defined('HHVM_VERSION_ID')) { | ||
| $xCast = <<<EODUMP |
There was a problem hiding this comment.
Should we use nowdoc? See #17086.
nicolas-grekas
force-pushed
the
dump-redis
branch
2 times, most recently
from
e79b572
to
0b73d77
Compare
nicolas-grekas
force-pushed
the
dump-redis
branch
from
0b73d77
to
56ae8c8
Compare
|
ping @symfony/deciders |
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Add Redis caster | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Helps working on Redis connections Commits ------- 56ae8c8 [VarDumper] Add Redis caster
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps working on Redis connections