New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Show aliases in command description instead of in different lines in application description #18790
Conversation
$text = ''; | ||
$aliases = $command->getAliases(); | ||
|
||
if(count($aliases) > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ($aliases) {
👍 as new feature on master, after comments are fixed |
Hi @nicolas-grekas thanks for the review, I think I amended all your comments. |
Looks great 👍 ! |
Thank you @juanmirod. |
Thanks to you, I am glad to have contributed to the project. |
This PR is a suggestion about the bug referenced in ticket 18351. The problem is that aliases create new lines with identical descriptions in the application description, it is suggested to show the aliases in the command description.
I had to modify one application fixture to meet this new behaviour and make the tests pass, but I don't think that a new application fixture is needed to test this having the application fixture 2.
Comments are welcome, this is my first PR in Symfony so if I need to meet any more requirements to make it correct to merge just tell me please.