[Config] Allow schemed paths in FileResource #18820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
|
👍 Status: reviewed |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 23, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [Config] Allow schemed paths in FileResource | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17598 | License | MIT | Doc PR | - This is a small new feature fixing a BC break that has been introduced in #17598 on 3.1. It happens that 3.1 is breaking a `phar` app on our side where we end up doing something like `new FileResource('phar://...')`. Ping @xabbuh and @javiereguiluz esp. Commits ------- c73f34d [Config] Allow schemed path in FileResource
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small new feature fixing a BC break that has been introduced in #17598 on 3.1.
It happens that 3.1 is breaking a
pharapp on our side where we end up doing something likenew FileResource('phar://...').Ping @xabbuh and @javiereguiluz esp.