[Serializer] Fix denormalization of arrays #19649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
fix_collections
branch
from
647fdf9
to
4603627
Compare
| $builtinType = isset($context['key_type']) ? $context['key_type']->getBuiltinType() : null; | ||
| foreach ($data as $key => $value) { | ||
| if (null !== $builtinType && !call_user_func('is_'.$builtinType, $key)) { | ||
| throw new UnexpectedValueException(sprintf('The type of the key "%s" must be "%s" ("%s" given).', $key, $builtinType, gettype($key))); |
There was a problem hiding this comment.
No need for the brackets, just a comma
There was a problem hiding this comment.
Brackets are used for the similar exception here https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php#L270
WSYT of standardizing messages with the rest of the code base in another PR?
|
👍 |
| /** | ||
| * @var ObjectInner[] | ||
| */ | ||
| private $inners; |
There was a problem hiding this comment.
if we're missing this phpdoc, the serializer won't try to normalize inner before calling setInners() right?
There was a problem hiding this comment.
If there is no type defined (through a PHPDoc or any other way supported by registered extractors), the old behavior (don't check anything) occurs.
|
👍 |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Aug 19, 2016
This PR was squashed before being merged into the 3.1 branch (closes #19649). Discussion ---------- [Serializer] Fix denormalization of arrays | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19545 | License | MIT | Doc PR | n/a ping @hensoko @theofidry Commits ------- 99c582b [Serializer] Fix denormalization of arrays
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @hensoko @theofidry