[Serializer] minor: Remove an extra space in a YamlFileLoader error #20174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Oct 6, 2016
dunglas
commented
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
|
👍 |
1 similar comment
|
👍 |
fabpot
reviewed
Oct 6, 2016
| @@ -90,7 +90,7 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata) | |||
|
|
|||
| if (isset($data['max_depth'])) { | |||
| if (!is_int($data['max_depth'])) { | |||
| throw new MappingException('The "max_depth" value must an integer in "%s" for the attribute "%s" of the class "%s".', $this->file, $attribute, $classMetadata->getName()); | |||
| throw new MappingException('The "max_depth" value must an integer in "%s" for the attribute "%s" of the class "%s".', $this->file, $attribute, $classMetadata->getName()); | |||
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Oct 7, 2016
…oader error (dunglas) This PR was squashed before being merged into the 3.1 branch (closes #20174). Discussion ---------- [Serializer] minor: Remove an extra space in a YamlFileLoader error | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- a1bc96b [Serializer] minor: Remove an extra space in a YamlFileLoader error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.