[SecurityBundle] Cache contexts per request in FirewallMap #20196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Oct 10, 2016
| @@ -26,18 +26,24 @@ class FirewallMap implements FirewallMapInterface | |||
| { | |||
| protected $container; | |||
| protected $map; | |||
| protected $contexts; | |||
chalasr
force-pushed
the
securitybundle/cache_contexts_per_request
branch
from
0593495
to
ffacec1
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Oct 12, 2016
…ap (chalasr) This PR was merged into the 3.2-dev branch. Discussion ---------- [SecurityBundle] Cache contexts per request in FirewallMap | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19819 (comment) | License | MIT | Doc PR | n/a From @HeahDude in #19819 (comment), I propose to store and retrieve `Context` objects per `Request` using `SplObjectStorage`. At the moment, contexts are consumed by the `Symfony\Components\Security\Http\Firewall` class only, but they could be indirectly by end users if #19490 and/or #19819 come to be merged. Commits ------- ffacec1 [SecurityBundle] Cache contexts per request in FirewallMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @HeahDude in #19819 (comment), I propose to store and retrieve
Contextobjects perRequestusingSplObjectStorage.At the moment, contexts are consumed by the
Symfony\Components\Security\Http\Firewallclass only, but they could be indirectly by end users if #19490 and/or #19819 come to be merged.