[#18637][TranslationDebug] workaround for getFallbackLocales. #20465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Nov 9, 2016
aitboudad
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18637 |
| License | MIT |
| Doc PR | ~ |
ro0NL
reviewed
Nov 9, 2016
| if (is_dir($path)) { | ||
| $loader->loadMessages($path, $fallbackCatalogue); | ||
| } | ||
| $fallbackLocales = []; |
| } catch (\Throwable $e) { | ||
| } | ||
| } elseif ($translator instanceof Translator) { | ||
| $fallbackLocales = $translator->getFallbackLocales(); |
There was a problem hiding this comment.
What about a new interface for this? Or at least actually define this method? Imo. we should not rely on the magic __call behavior of these translators.
There was a problem hiding this comment.
What about a new interface for this?
seems better!
Imo. we should not rely on the magic __call behavior of these translators.
right, It was added for BC and I think we should deprecate this behavior
There was a problem hiding this comment.
I defined this method for the moment
aitboudad
force-pushed
the
issue_18637
branch
from
991d20a
to
31deea1
Compare
|
@aitboudad since you introduced two new public method, could you please add tests for them ? |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2016
…es. (aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [#18637][TranslationDebug] workaround for getFallbackLocales. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18637 | License | MIT | Doc PR | ~ Commits ------- 31deea1 [TranslationDebug] workaround for getFallbackLocales.
This was referenced Nov 17, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.