[Process] Fix process continuing after reached timeout using getIterator() #20600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Nov 22, 2016
chalasr
commented
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20594 |
| License | MIT |
| Doc PR | n/a |
chalasr
force-pushed
the
fix/process/get_iterator_timeout
branch
4 times, most recently
from
c625d85
to
f96dc2e
Compare
| @@ -558,6 +558,7 @@ public function getIterator($flags = 0) | |||
| } | |||
|
|
|||
| $this->readPipesForOutput(__FUNCTION__, $blocking); | |||
| $this->checkTimeout(); | |||
There was a problem hiding this comment.
should be above line 560, isn't it?
chalasr
force-pushed
the
fix/process/get_iterator_timeout
branch
from
f96dc2e
to
10992cd
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2016
…ng getIterator() (chalasr) This PR was merged into the 3.1 branch. Discussion ---------- [Process] Fix process continuing after reached timeout using getIterator() | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20594 | License | MIT | Doc PR | n/a Commits ------- 10992cd [Process] Fix kill process on reached timeout using getIterator()
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.