[FrameworkBundle] Forbid env parameters in routing configuration #20687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 29, 2016
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20682 |
| License | MIT |
| Doc PR | - |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2016
…ration (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Forbid env parameters in routing configuration | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20682 | License | MIT | Doc PR | - Commits ------- a931002 [FrameworkBundle] Forbid env parameters in routing configuration
Merged
|
Hello! My routing definitions are dependent on host. Host is environment-dependent variable: routing_api:
resource: routing_api.yml
prefix: /
condition: "request.server.get('HTTP_HOST') === '%env(API_HOST)%'"The application is running inside a container so It should stay environment dependent, otherwise the api host will be stored in the cache and the |
|
The easiest way I found is to warmup the cache every time by doing this in the docker rm -rf var/cache/*
php bin/console cache:warmup --env=$SYMFONY_ENV
chown -R www-data var/cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.