New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Fix dump block is unfairly restrained #20716

Merged
merged 1 commit into from Dec 2, 2016

Conversation

Projects
None yet
4 participants
@ogizanagi
Copy link
Member

ogizanagi commented Dec 1, 2016

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

The display: table-row rule does not suit well for such blocks and prevent from containing them properly in the parent container (thus the reason why the width was set to 200px I guess).

Before

screenshot 2016-12-01 a 20 21 49

After

screenshot 2016-12-01 a 20 21 14

(max width is still fixed to 480px by .sf-toolbar-block:hover .sf-toolbar-info)

@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Dec 2, 2016

A big 👍 from me. @ogizanagi thanks for this much needed fix.

@stof

This comment has been minimized.

Copy link
Member

stof commented Dec 2, 2016

👍

@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Dec 2, 2016

Thanks @ogizanagi.

@javiereguiluz javiereguiluz merged commit 997beb2 into symfony:2.8 Dec 2, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

javiereguiluz added a commit that referenced this pull request Dec 2, 2016

bug #20716 [WebProfilerBundle] Fix dump block is unfairly restrained …
…(ogizanagi)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] Fix dump block is unfairly restrained

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

The `display: table-row` rule does not suit well for such blocks and prevent from containing them properly in the parent container (thus the reason why the width was set to `200px` I guess).

### Before

<img width="539" alt="screenshot 2016-12-01 a 20 21 49" src="https://cloud.githubusercontent.com/assets/2211145/20808878/8af6faa2-b804-11e6-8656-8ebd710b4acb.PNG">

### After

<img width="524" alt="screenshot 2016-12-01 a 20 21 14" src="https://cloud.githubusercontent.com/assets/2211145/20808885/9106b0cc-b804-11e6-9ddc-0cc09a546274.PNG">

(max width is still fixed to `480px` by `.sf-toolbar-block:hover .sf-toolbar-info`)

Commits
-------

997beb2 [WebProfilerBundle] Fix dump block is unfairly restrained

@ogizanagi ogizanagi deleted the ogizanagi:fix/2.8/wdt_dump_width branch Dec 2, 2016

This was referenced Dec 13, 2016

ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018

bug symfony#20716 [WebProfilerBundle] Fix dump block is unfairly rest…
…rained (ogizanagi)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] Fix dump block is unfairly restrained

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

The `display: table-row` rule does not suit well for such blocks and prevent from containing them properly in the parent container (thus the reason why the width was set to `200px` I guess).

### Before

<img width="539" alt="screenshot 2016-12-01 a 20 21 49" src="https://cloud.githubusercontent.com/assets/2211145/20808878/8af6faa2-b804-11e6-8656-8ebd710b4acb.PNG">

### After

<img width="524" alt="screenshot 2016-12-01 a 20 21 14" src="https://cloud.githubusercontent.com/assets/2211145/20808885/9106b0cc-b804-11e6-9ddc-0cc09a546274.PNG">

(max width is still fixed to `480px` by `.sf-toolbar-block:hover .sf-toolbar-info`)

Commits
-------

997beb2 [WebProfilerBundle] Fix dump block is unfairly restrained
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment