[Validator] Fix issue 12302 - cache constraints #20740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to still cache constraints even when an uncachable constraint (i.e. Callback) is added to a parent class at runtime. This is achived by caching only the constraints that are loaded for the class in question only and merging parent and interface constraints after reading from cache.
| 'Entity', | ||
| ))), | ||
|
|
| @@ -43,10 +44,9 @@ public function testMergeParentConstraints() | |||
| $metadata = $factory->getMetadataFor(self::CLASS_NAME); | |||
|
|
|||
| $constraints = array( | |||
|
|
|||
| $factory = new LazyLoadingMetadataFactory(new TestLoader(), $cache); | ||
|
|
||
| $cache | ||
| ->expects($this->any()) |
There was a problem hiding this comment.
4 spaces indendation (same below)
| return $this->loadedClasses[$class] = $metadata; | ||
| } | ||
|
|
||
| protected function mergeConstraints(ClassMetadata $metadata) |
There was a problem hiding this comment.
can this be made private?
|
If this is a bug, it should be submitted again the lowest branch where it applies. Do you know which branch this should be? Can you rebase + change the base branch on github (click on "Edit" near the PR title). |
|
This was already present in 2.3 but as I understand, this version is not maintained any more so I will look at the 2.7 branch. |
|
See #20793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to still cache constraints even when an un-cachable constraint (i.e. Callback)
is added to a parent class at runtime.
This is achieved by caching the constraints that are loaded for the class in question only
and merging parent and interface constraints after reading from cache.