[Config] Improve PHPdoc / IDE autocomplete #21047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Dec 25, 2016
| @@ -142,7 +142,7 @@ public function enumPrototype() | |||
| * If this function has been called and the node is not set during the finalization | |||
| * phase, it's default value will be derived from its children default values. | |||
| * | |||
| * @return ArrayNodeDefinition | |||
| * @return $this | |||
|
I'd be in favor of moving this to a lower branch. |
|
Agree.. ill try rebasing 2.7 somewhere today. |
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 28, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Config] Improve PHPdoc / IDE autocomplete | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> The missing pieces for fixing the autocomplete in IDE's (tested in `PhpStorm 2016.3.2`). Each method seems to be found now for the framework bundle configuration 😱 Actually uses #20923 where needed, but i think we should go with it consistently. Relates to #20290 (comment) Commits ------- 3f3c6e0 [Config] Improve PHPdoc / IDE autocomplete
fabpot
added a commit
that referenced
this pull request
Apr 1, 2019
…ee builder (Koc) This PR was merged into the 4.2 branch. Discussion ---------- [Config] Improve PHPdoc / IDE autocomplete for config tree builder | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - follow up of #27476 and #21047 Commits ------- 21f7977 Improve PHPdoc / IDE autocomplete for config tree builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing pieces for fixing the autocomplete in IDE's (tested in
PhpStorm 2016.3.2).Each method seems to be found now for the framework bundle configuration 😱
Actually uses #20923 where needed, but i think we should go with it consistently.
Relates to #20290 (comment)