No fallback to REQUEST_TIME in TimeDataCollector #21156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -29,7 +29,7 @@ public function testCollect() | |||
|
|
|||
| $c->collect($request, new Response()); | |||
|
|
|||
| $this->assertEquals(1000, $c->getStartTime()); | |||
| $this->assertEquals(0, $c->getStartTime()); | |||
There was a problem hiding this comment.
shouldn't you change line 28 instead?
There was a problem hiding this comment.
That test is already covered on line 34. I wanted to keep this case as a regression that REQUEST_TIME is not used when REQUEST_TIME_FLOAT is not filled in
|
Thank you @iltar. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 6, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- No fallback to REQUEST_TIME in TimeDataCollector | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no (?) | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ As of PHP 5.4 the `REQUEST_TIME_FLOAT` is available and the minimum version of PHP is 5.5 in Symfony. I think it's safe to use as I can't find cases where this is _not_ defined. Commits ------- ba00543 No fallback to REQUEST_TIME in TimeDataCollector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 5.4 the
REQUEST_TIME_FLOATis available and the minimum version of PHP is 5.5 in Symfony. I think it's safe to use as I can't find cases where this is not defined.