simple-phpunit requires the zip extension #21303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -43,6 +43,9 @@ if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit") || md5_file(__ | |||
| @unlink("$PHPUNIT_VERSION.zip"); | |||
| passthru("wget https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip"); | |||
| } | |||
| if (!class_exists('ZipArchive')) { | |||
| throw new \Exception('simple-phpunit requires the PHP extension for zip support to be installed and enabled in order to download the right version of phpunit'); | |||
There was a problem hiding this comment.
Proposal for a slightly different error message:
simple-phpunit requires the "zip" PHP extension to be installed and enabled in order to uncompress the downloaded PHPUnit packages
There was a problem hiding this comment.
yep, thats better. updated
dbu
force-pushed
the
phpunit-bridge-zip-extension
branch
from
e87f53e
to
d651051
Compare
xabbuh
reviewed
Jan 16, 2017
| @@ -43,6 +43,9 @@ if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit") || md5_file(__ | |||
| @unlink("$PHPUNIT_VERSION.zip"); | |||
| passthru("wget https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip"); | |||
| } | |||
| if (!class_exists('ZipArchive')) { | |||
| throw new \Exception('simple-phpunit requires the "zip" PHP extension to be installed and enabled in order to uncompress the downloaded PHPUnit packages'); | |||
There was a problem hiding this comment.
We usually terminate exception messages with a dot.
|
👍 |
dbu
force-pushed
the
phpunit-bridge-zip-extension
branch
from
d651051
to
6628e76
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @dbu. |
stof
added a commit
that referenced
this pull request
Jan 16, 2017
This PR was merged into the 3.2 branch. Discussion ---------- simple-phpunit requires the zip extension without the zip extension enabled, i get `PHP Fatal error: Uncaught Error: Class 'ZipArchive' not found in .../vendor/bin/simple-phpunit:46` | Q | A | ------------- | --- | Branch? | 3.2 (first version containing the script) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21060 | License | MIT | Doc PR | - Commits ------- 6628e76 simple-phpunit requires the zip extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without the zip extension enabled, i get
PHP Fatal error: Uncaught Error: Class 'ZipArchive' not found in .../vendor/bin/simple-phpunit:46