Fix upgrade guide #21314
Fix upgrade guide #21314
Conversation
|
Did you make sure that the missing parts just aren't things that were not deprecated in 2.7, but were only deprecated in 2.8? |
|
Should't that be the same? Also, a big missing part was the one about the Form deprecations, that I'm sure are from before 2.8. Anyway, I'll double check that... |
| together with the `Valid` constraint instead. | ||
|
|
||
| * Type names were removed. Instead of referencing types by name, you must | ||
| reference them by their fully-qualified class name (FQCN) instead: |
There was a problem hiding this comment.
That's wrong. All these Form changes are part of Symfony 2.8, so they have nothing to do in the UPGRADE file in the 2.7 branch
| @@ -1,6 +1,35 @@ | |||
| UPGRADE FROM 2.x to 3.0 | |||
There was a problem hiding this comment.
does it even make sense to have this title?
I mean: we do not support direct upgrade from 2.x to 3.0, when x < 8.
Jean85
force-pushed
the
fix_upgrade_guide
branch
from
f64cf36
to
87a9530
Compare
|
Ok I've rechecked everything. I've changed the base branch to 2.8, and leaved only the changes that where really missing: the Monolog Bridge |
| * `Symfony\Bridge\Monolog\Logger::err()` was removed. Use `error()` which is PSR-3 compatible. | ||
| * `Symfony\Bridge\Monolog\Logger::warn()` was removed. Use `warning()` which is PSR-3 compatible. | ||
|
|
||
| * Removed the feature that allowed finding deep items in `ParameterBag::get()`. |
There was a problem hiding this comment.
this has nothing to do with the monolog bridge. you copy/pasted the changes of HttpFoundation below
There was a problem hiding this comment.
Merge screwup, sorry. Removed.
|
👍 |
| * `Symfony\Bridge\Monolog\Logger::emerg()` was removed. Use `emergency()` which is PSR-3 compatible. | ||
| * `Symfony\Bridge\Monolog\Logger::crit()` was removed. Use `critical()` which is PSR-3 compatible. | ||
| * `Symfony\Bridge\Monolog\Logger::err()` was removed. Use `error()` which is PSR-3 compatible. | ||
| * `Symfony\Bridge\Monolog\Logger::warn()` was removed. Use `warning()` which is PSR-3 compatible. |
There was a problem hiding this comment.
The deprecations are present in the 2.7 branch too: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bridge/Monolog/Logger.php#L30
There was a problem hiding this comment.
Should I change the base branch to 2.7 then?
There was a problem hiding this comment.
That would be great. Otherwise we can do that while merging. But could you update the PR description please?
There was a problem hiding this comment.
Done and done, I've completely rewritten this branch to avoid a big mess.
Jean85
force-pushed
the
fix_upgrade_guide
branch
from
efa6fcd
to
bd0c206
Compare
|
Thank you @Jean85. |
This PR was merged into the 2.7 branch. Discussion ---------- Fix upgrade guide | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT This merges back the `UPGRADE-3.0.md` guide from master back up to 2.7. There were a lot of missing parts and a few duplications. I fear that also the other guides have the same issues. Commits ------- bd0c206 Add missing pieces in the upgrade guide to 3.0
This merges back the
UPGRADE-3.0.mdguide from master back up to 2.7. There were a lot of missing parts and a few duplications. I fear that also the other guides have the same issues.