[Serializer] Xml encoder throws exception for valid data #21671
Conversation
gr1ev0us
force-pushed
the
ticket_21617
branch
2 times, most recently
from
ca8c279
to
65280e9
Compare
* add tests for bool and object encoding * fix encoding for object in array and field
gr1ev0us
force-pushed
the
ticket_21617
branch
from
65280e9
to
3fd7f53
Compare
| private $encoder; | ||
|
|
||
| /** |
There was a problem hiding this comment.
This comment is useless (the IDE will be able to infer the type using the default value).
| @@ -524,4 +534,96 @@ protected function getObject() | |||
|
|
|||
| return $obj; | |||
| } | |||
|
|
|||
| /** | |||
| * @test | |||
There was a problem hiding this comment.
This block is useless (same below).
| */ | ||
| public function testEncodeXmlWithBoolValue() | ||
| { | ||
| $expectedXml = '<?xml version="1.0"?> |
There was a problem hiding this comment.
You may use the heredoc syntax (the IDE will be able to highlight the snippet). (Just suggestion, not mandatory).
| <response><foo>1</foo><bar>0</bar></response> | ||
| '; | ||
|
|
||
| $actualXml = $this->encoder->encode(array('foo' => true, 'bar' => false), 'xml'); |
There was a problem hiding this comment.
I don't get why this is expected? IMO it should be array('foo' => '1', 'bar' => '0') unless explicitly defined as bool in a XML schema.
There was a problem hiding this comment.
This is an actual behavior of XmlEncode, to cast bool to int. I am not sure that i should fix this non explicit behaviour, so i am just cover that with test.
| @@ -11,19 +11,29 @@ | |||
|
|
|||
| namespace Symfony\Component\Serializer\Tests\Encoder; | |||
|
|
|||
| use DateTime; | |||
There was a problem hiding this comment.
For classes in the global namespace, we don't import them (use \DateTime directly).
nicolas-grekas
changed the title
| @@ -12,18 +12,24 @@ | |||
| namespace Symfony\Component\Serializer\Tests\Encoder; | |||
|
|
|||
| use PHPUnit\Framework\TestCase; | |||
| use Symfony\Component\Serializer\Tests\Fixtures\Dummy; | |||
There was a problem hiding this comment.
please revert any change related to ordering: our policy is to add new lines in alpha order, but keep old ones as is - to help for merges between branches.
gr1ev0us
force-pushed
the
ticket_21617
branch
from
fe71024
to
88bfde5
Compare
|
@dunglas Is this one ok for you? |
|
👍 |
|
Thank you @gr1ev0us. |
…gr1ev0us) This PR was squashed before being merged into the 2.7 branch (closes #21671). Discussion ---------- [Serializer] Xml encoder throws exception for valid data | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21617 | License | MIT | Doc PR | None #21617 Xml encoder throws exception for valid data - add tests for bool and object encoding - fix encoding for object in array and field Commits ------- 5c2d4c6 [Serializer] Xml encoder throws exception for valid data
… data (gr1ev0us) This PR was squashed before being merged into the 2.7 branch (closes symfony#21671). Discussion ---------- [Serializer] Xml encoder throws exception for valid data | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#21617 | License | MIT | Doc PR | None symfony#21617 Xml encoder throws exception for valid data - add tests for bool and object encoding - fix encoding for object in array and field Commits ------- 5c2d4c6 [Serializer] Xml encoder throws exception for valid data
#21617 Xml encoder throws exception for valid data