[SecurityBundle] Don't normalize username of in-memory users

[chalasr]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

It's common to have e.g. emails as keys in security.providers.in_memory.users since keys are username. Actually they are normalized so foo-bar@gmail.com becomes foo_bar@gmail.com and authentication fails unexpectedly.

[fabpot]

That's a BC break (probably just for tests in end-users apps, but still). I would document the change and merge it on master.

[chalasr]

Change documented and rebased on master.

[stof]

@fabpot ideally, we should skip normalized for all prototyped nodes (and even remove the explicit config), but this is a BC break.
Transforming keys selected by the user is generally a WTF moment, especially if they need to use these keys elsewhere.
The normalization was added to allow writing XML config files feeling native, but keys for prototyped nodes are inside attribute values, and so don't need to use dashes to feel native.

I don't see a way to easily disable key normalization for prototyped nodes in an fully BC way though (even though it would break BC only for people who faced the WTF moment and decided to keep a WTF config files forever rather than using an underscore explicitly)

[fabpot]

Thank you @chalasr.