[HttpKernel] Skip ContainerAwareInterface::setContainer from service_arguments actions registration #22340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
service_args-skip-setcontainer
branch
from
1a1e3ad
to
8e00800
Compare
| @@ -65,11 +66,15 @@ public function process(ContainerBuilder $container) | |||
| if (!$r = $container->getReflectionClass($class)) { | |||
| throw new InvalidArgumentException(sprintf('Class "%s" used for service "%s" cannot be found.', $class, $id)); | |||
| } | |||
| $isContainerAware = $r->implementsInterface(ContainerAwareInterface::class); | |||
There was a problem hiding this comment.
missing || $r->isSubclassOf(AbstractController::class);
chalasr
force-pushed
the
service_args-skip-setcontainer
branch
4 times, most recently
from
dac676c
to
c0c5c37
Compare
…ions registration
chalasr
force-pushed
the
service_args-skip-setcontainer
branch
from
c0c5c37
to
ad59e18
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2017
…om service_arguments actions registration (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpKernel] Skip ContainerAwareInterface::setContainer from service_arguments actions registration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a As it would never be used Commits ------- ad59e18 Skip ContainerAwareInterface::setContainer from service_arguments actions registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it would never be used