fail when detecting risky tests #22387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see https://travis-ci.org/symfony/symfony/builds/221231962 for how such a failing build looks like |
xabbuh
force-pushed
the
fail-on-risky
branch
2 times, most recently
from
a552d21
to
4a057ec
Compare
xabbuh
commented
Apr 12, 2017
| @@ -34,7 +34,7 @@ protected function tearDown() | |||
| } | |||
|
|
|||
| /** | |||
| * @dataProvider testRenderProvider | |||
| * @dataProvider renderProvider | |||
xabbuh
commented
Apr 12, 2017
| @@ -153,6 +153,8 @@ public function testSetDefault() | |||
| public function testSetDefaultAcceptsEn() | |||
| { | |||
| $this->call('setDefault', 'en'); | |||
|
|
|||
| $this->assertSame('en', $this->call('getDefault')); | |||
xabbuh
commented
Apr 12, 2017
| @@ -22,7 +22,7 @@ | |||
| "require-dev": { | |||
| "symfony/asset": "~2.7", | |||
| "symfony/finder": "~2.3", | |||
| "symfony/form": "~2.7.25|^2.8.18", | |||
| "symfony/form": "~2.7.26|^2.8.19", | |||
There was a problem hiding this comment.
needed to pull in https://github.com/symfony/symfony/pull/22066/files#diff-e11656489f1e01413320bd5edff0f0c7 to satisfy the deps=low job
xabbuh
commented
Apr 12, 2017
| @@ -40,7 +40,7 @@ | |||
| "symfony/dom-crawler": "^2.0.5", | |||
| "symfony/intl": "~2.3", | |||
| "symfony/security": "~2.6", | |||
| "symfony/form": "~2.7.25|^2.8.18", | |||
| "symfony/form": "~2.7.26|^2.8.19", | |||
There was a problem hiding this comment.
needed to pull in https://github.com/symfony/symfony/pull/22066/files#diff-e11656489f1e01413320bd5edff0f0c7 to satisfy the deps=low job
Merged
keradus
approved these changes
Apr 12, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Apr 12, 2017
This PR was merged into the 2.7 branch. Discussion ---------- fail when detecting risky tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The `--fail-on-risky` option is available since sebastianbergmann/phpunit@7e06a82 which was first released with PHPUnit 5.2. Commits ------- 3792ee6 fail when detecting risky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--fail-on-riskyoption is available since sebastianbergmann/phpunit@7e06a82 which was first released with PHPUnit 5.2.