Throwing an exception if the class is not found

[weaverryan]

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

We now throw an exception if the user makes a mistake with their PSR-4 prefix and namespace. For example:

AppBundle\Controller\:
    resource: '../../src/AppBundle/{Controller}'
    public: true

I should not have the \Controller at the end of the key. Previously, it would silently not import any services from the directory. Now it throws:

Expected to find class "AppBundle\Controller\Controller\Admin\BlogController" in file "/path/to/project/src/AppBundle/Controller/Admin/BlogController.php" while importing services from resource "../../src/AppBundle/{Controller}", but it was not found! Check the namespace prefix used with the resource.

The only "downside" is that this prevents someone from importing files from a resource that has a file with no class in it (functions.php). @nicolas-grekas and I decided today that we can throw an exception now to be safe, and see if anyone has that valid use-case.

Cheers!

[nicolas-grekas]

👍

[nicolas-grekas]

oups, tests are failing

[weaverryan]

Tests should be happy now. There is one other behavior change that caused the failure: if a class that we try to load extends a non-existent class, then:

• Before, we silently skipped loading that service
• After, we allow the normal, fatal, class not found error

I think this is perfectly in spirit with this change, which is: fail if something is wrong :). If someone comes up with a use-case later to NOT fail, we can update the behavior without any BC issues.

[nicolas-grekas]

Thank you @weaverryan.