Filesystem: annotate the one network test with a "network" group. #22630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that require network access can be problematic, because they depend on some external state not under your control. That can lead to "random" failures when the code in question actually works fine. The Filesystem component has one such test, and this commit adds it to the "network" group (for PHPUnit). Doing so lets the user skip that particular test, by running phpunit with the --exclude-group flag. We take advantage of this in Gentoo, where every user has the ability to run the test suite but network access is forbidden.
|
Thank you @orlitzky. |
fabpot
added a commit
that referenced
this pull request
May 4, 2017
…k" group. (orlitzky) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #22630). Discussion ---------- Filesystem: annotate the one network test with a "network" group. This is one tiny commit that lets us avoid hitting the network while running the test suite. We've packaged symfony-filesystem in Gentoo, and our users can run the test suite when they install it. However, network access is forbidden during the test phase (it causes spurious failures, privacy issues, etc.). By marking the one network test with `@group network`, we are able to skip it with `--exclude-group network`. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- fd0dd57 Filesystem: annotate the one network test with a "network" group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one tiny commit that lets us avoid hitting the network while running the test suite. We've packaged symfony-filesystem in Gentoo, and our users can run the test suite when they install it. However, network access is forbidden during the test phase (it causes spurious failures, privacy issues, etc.). By marking the one network test with
@group network, we are able to skip it with--exclude-group network.