[Workflow] Move twig extension registration to twig bundle #22652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
May 8, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [Workflow] fix use directives | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Spotted while creating #22652 Commits ------- 08f4ad2 [Workflow] fix use directives
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
May 8, 2017
… (ogizanagi) This PR was merged into the 3.2 branch. Discussion ---------- [Workflow] Move twig extension registration to twig bundle | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | not really | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A It's probably very late, but I think the twig extension registration is supposed to be done from the `TwigBundle` rather than the `FrameworkBundle`. Fortunately, it doesn't cause any issue currently when using the framework bundle and the workflow component without twig, because it only creates a `workflow.twig_extension` service you'll probably never call, and the `twig.extension` tag is never processed. But still, creates a useless service that cannot be called (and is not removed because it's public). So this PR aims for consistency over other twig extensions registration, and removing this service when not using twig. It isn't a BC break to me, as you usually already use the `TwigBundle` for other extensions. Commits ------- 3fc80d1 [Workflow] Move twig extension registration to twig bundle
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably very late, but I think the twig extension registration is supposed to be done from the
TwigBundlerather than theFrameworkBundle. Fortunately, it doesn't cause any issue currently when using the framework bundle and the workflow component without twig, because it only creates aworkflow.twig_extensionservice you'll probably never call, and thetwig.extensiontag is never processed. But still, creates a useless service that cannot be called (and is not removed because it's public).So this PR aims for consistency over other twig extensions registration, and removing this service when not using twig.
It isn't a BC break to me, as you usually already use the
TwigBundlefor other extensions.