[FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator #22808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ogizanagi
commented
May 20, 2017
•
ogizanagi
commented
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #22800 (comment) |
| License | MIT |
| Doc PR | N/A |
|
This just tweaks #21730, I would do it on 3.3 if doable (to avoid a second upgrade path on the next minor for the same code area). Anyway this looks good to me |
|
@nicolas-grekas : What do you think about this one? Keeping it for 3.4, or re-targeting to 3.3? |
|
Let's go for 3.3 |
|
Re-targeted. |
|
test fail, typo in error deprecation message |
…iases over using the service locator
|
Fixed. |
xabbuh
approved these changes
May 22, 2017
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2017
…or instances/aliases over using the service locator (ogizanagi) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #22800 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- df747ce [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.