New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator #22808

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
5 participants
@ogizanagi
Member

ogizanagi commented May 20, 2017

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #22800 (comment)
License MIT
Doc PR N/A
@chalasr

This comment has been minimized.

Show comment
Hide comment
@chalasr

chalasr May 21, 2017

Member

This just tweaks #21730, I would do it on 3.3 if doable (to avoid a second upgrade path on the next minor for the same code area). Anyway this looks good to me

Member

chalasr commented May 21, 2017

This just tweaks #21730, I would do it on 3.3 if doable (to avoid a second upgrade path on the next minor for the same code area). Anyway this looks good to me

@ogizanagi

This comment has been minimized.

Show comment
Hide comment
@ogizanagi

ogizanagi May 21, 2017

Member

@nicolas-grekas : What do you think about this one? Keeping it for 3.4, or re-targeting to 3.3?

Member

ogizanagi commented May 21, 2017

@nicolas-grekas : What do you think about this one? Keeping it for 3.4, or re-targeting to 3.3?

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas May 21, 2017

Member

Let's go for 3.3

Member

nicolas-grekas commented May 21, 2017

Let's go for 3.3

@ogizanagi ogizanagi changed the base branch from 3.4 to 3.3 May 21, 2017

@ogizanagi

This comment has been minimized.

Show comment
Hide comment
@ogizanagi

ogizanagi May 21, 2017

Member

Re-targeted.

Member

ogizanagi commented May 21, 2017

Re-targeted.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas May 21, 2017

Member

test fail, typo in error deprecation message

Member

nicolas-grekas commented May 21, 2017

test fail, typo in error deprecation message

@nicolas-grekas nicolas-grekas modified the milestones: 3.3, 3.4 May 21, 2017

@ogizanagi

This comment has been minimized.

Show comment
Hide comment
@ogizanagi

ogizanagi May 21, 2017

Member

Fixed.

Member

ogizanagi commented May 21, 2017

Fixed.

@nicolas-grekas

👍

@xabbuh

xabbuh approved these changes May 22, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas
Member

nicolas-grekas commented May 23, 2017

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit df747ce into symfony:3.3 May 23, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 23, 2017

feature #22808 [FrameworkBundle][Validator] Deprecate passing validat…
…or instances/aliases over using the service locator (ogizanagi)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator

| Q             | A
| ------------- | ---
| Branch?       | 3.3 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #22800 (comment) <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

df747ce [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator

@ogizanagi ogizanagi deleted the ogizanagi:deprec/3.4/fwb/constraint_validator_factory_2nd_arg branch May 23, 2017

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment