[DI] Remove deprecated case insensitive service ids #22811

ro0NL · 2017-05-20T21:12:39Z

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT
Doc PR	symfony/symfony-docs#...

See #21223

nicolas-grekas · 2017-05-21T13:44:43Z

src/Symfony/Component/DependencyInjection/CHANGELOG.md

+4.0.0
+-----
+
+ * [BC BREAK] removed support for case insensitive service identifiers


BC BREAK prefix not needed

nicolas-grekas · 2017-05-21T13:52:24Z

I think we need a proper behavior + test when two services are defined (ie pre-compile, using ContainerBuilder) and they have an id that differs only by the case: either it works properly (does it already?) or fail early (might be more DX friendly?)

ro0NL · 2017-05-21T15:22:53Z

method map seems prepared :)

         $this->methodMap = array(
-            'bar' => 'getBarService',
+            'BAR' => 'getBARService',
+            'BAR2' => 'getBAR2Service',
+            'bar' => 'getBar3Service',
+            'bar2' => 'getBar22Service',

will add one more test for PhpDumper :) but i think it works properly 👍

ro0NL · 2017-05-21T15:46:17Z

src/Symfony/Component/DependencyInjection/Tests/Fixtures/graphviz/services9.dot

@@ -30,6 +30,9 @@ digraph sc {
  node_lazy_context [label="lazy_context\nLazyContext\n", shape=record, fillcolor="#eeeeee", style="filled"];
  node_lazy_context_ignore_invalid_ref [label="lazy_context_ignore_invalid_ref\nLazyContext\n", shape=record, fillcolor="#eeeeee", style="filled"];
  node_closure_proxy [label="closure_proxy\nBarClass\n", shape=record, fillcolor="#eeeeee", style="filled"];
+  node_bar [label="BAR\nstdClass\n", shape=record, fillcolor="#eeeeee", style="filled"];
+  node_bar2 [label="bar2\nstdClass\n", shape=record, fillcolor="#eeeeee", style="filled"];
+  node_bar2 [label="BAR2\nstdClass\n", shape=record, fillcolor="#eeeeee", style="filled"];


not sure this is actually needs to be lowercased, perhaps qualifies a bugfix (2.7).

edit: or master / this PR; as it's an issue as of now. Let me know.

IMO this needs to be fixed as part of this PR

Graphviz nodes seem to be case-sensitive. so removing the lowercase should fix this.

ro0NL · 2017-05-21T16:30:18Z

@nicolas-grekas geen! new tests are proper imo. and allows for future edge cases to be added. I think we should at least try out this behavior on master =/

Changes to Container.php best reviewed at https://github.com/symfony/symfony/pull/22811/files?w=1#diff-1df5b32be44d0f592ec285c6bbf386bb

fabbot.io failure seems unrelated :)

Ready for review.

nicolas-grekas · 2017-05-22T06:56:45Z

rebase needed

Tobion · 2017-05-26T11:49:26Z

src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php

@@ -1140,6 +1140,21 @@ public function testRegisterForAutoconfiguration()
        // when called multiple times, the same instance is returned
        $this->assertSame($childDefA, $container->registerForAutoconfiguration('AInterface'));
    }
+
+    public function testCaseInsensitivity()


should be testCaseSensitivity

Tobion · 2017-05-26T11:49:47Z

src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php

-     * @expectedDeprecation Service identifiers will be made case sensitive in Symfony 4.0. Using "Foo" instead of "foo" is deprecated since version 3.3.
-     */
-    public function testGetInsensitivity()
+    public function testCaseInsensitivity()


ro0NL · 2017-05-26T17:49:05Z

src/Symfony/Bridge/Doctrine/ManagerRegistry.php

@@ -49,7 +49,7 @@ protected function resetService($name)
        }
        $manager->setProxyInitializer(\Closure::bind(
            function (&$wrappedInstance, LazyLoadingInterface $manager) use ($name) {
-                if (isset($this->aliases[$name = strtolower($name)])) {
+                if (isset($this->aliases[$name])) {
                    $name = $this->aliases[$name];
                }
                $method = !isset($this->methodMap[$name]) ? 'get'.strtr($name, $this->underscoreMap).'Service' : $this->methodMap[$name];


@stof not sure here.. it seems forgotten? This is the only use-case of Container::$underscoreMap left.

methodMap will always be filled in 4.0 (we removed support for dumping a container with a custom dumper not dumping the method map)

ro0NL · 2017-05-26T18:10:30Z

should i remove the (deprecated) FactoryReturnTypePass while at it? removing the strtolower calls breaks test :)

cc @GuilhemN

GuilhemN · 2017-05-26T19:40:46Z

method map seems prepared :)

#18167 indeed added support for sensitivity while fixing the PhpDumper for non alphanumeric ids.

should i remove the (deprecated) FactoryReturnTypePass while at it?

I think it would be easier to review if it was done in another PR. Nothing would prevent you from merging this PR here though.

ro0NL · 2017-05-29T09:05:31Z

Reverted compiler passes, they need to have a look though :) as well as the Container::$underscoreMap thingy.

Other then that, i think this is ready :)

stof · 2017-06-26T10:47:25Z

src/Symfony/Bridge/Doctrine/ManagerRegistry.php

@@ -49,7 +49,7 @@ protected function resetService($name)
        }
        $manager->setProxyInitializer(\Closure::bind(
            function (&$wrappedInstance, LazyLoadingInterface $manager) use ($name) {
-                if (isset($this->aliases[$name = strtolower($name)])) {
+                if (isset($this->aliases[$name])) {
                    $name = $this->aliases[$name];
                }
                $method = !isset($this->methodMap[$name]) ? 'get'.strtr($name, $this->underscoreMap).'Service' : $this->methodMap[$name];


methodMap will always be filled in 4.0 (we removed support for dumping a container with a custom dumper not dumping the method map)

stof · 2017-06-26T10:48:32Z

src/Symfony/Bridge/Doctrine/ManagerRegistry.php

@@ -49,7 +49,7 @@ protected function resetService($name)
        }
        $manager->setProxyInitializer(\Closure::bind(
            function (&$wrappedInstance, LazyLoadingInterface $manager) use ($name) {
-                if (isset($this->aliases[$name = strtolower($name)])) {


this requires a bugfix in 3.3 first instead: we need to use the normalizedIds property here instead of lowercasing (internal storage does not use lowercase anymore)

fabpot · 2017-07-06T07:15:37Z

@ro0NL What's the status of this PR?

ro0NL · 2017-07-06T07:58:17Z

@fabpot i should rebase at least :) let me have a look tomorrow evening / saturday.

Status: needs work

ro0NL · 2017-07-07T18:06:41Z

@fabpot looks good to me 👍

?w=1

Status: needs review

Tobion · 2017-07-07T22:21:30Z

src/Symfony/Component/DependencyInjection/Container.php

@@ -28,7 +28,7 @@
 *
 * Parameter and service keys are case insensitive.
 *
- * A service id can contain lowercased letters, digits, underscores, and dots.
+ * A service id can contain letters, digits, underscores, and dots.


This doesn't seem correct anymore. Service ids are not actually validated are they? They can also contain namespace backslashes for example.

Imo this comment should be removed, a service id can indeed contain any character.

My guess is this was written from a file loader pov, As in fact any character is allowed as of 2.7.

Tobion · 2017-07-07T22:49:26Z

src/Symfony/Component/DependencyInjection/Container.php

@@ -28,7 +28,7 @@
 *
 * Parameter and service keys are case insensitive.


this is not up-to-date as well

Tobion · 2017-07-07T22:55:35Z

src/Symfony/Component/DependencyInjection/Container.php

@@ -28,7 +28,7 @@
 *
 * Parameter and service keys are case insensitive.
 *
- * A service id can contain lowercased letters, digits, underscores, and dots.
+ * A service id can contain letters, digits, underscores, and dots.
 * Underscores are used to separate words, and dots to group services


this should also mention that this is only relevant when you have several services of the same class. otherwise you can use service id == class name.

I removed the whole block =/ This is just some service id convention, not really related to the container at all; as it allows any character as mentioned.

The part about creating a method is outdated, as it only checks the method map now.

nicolas-grekas · 2017-07-11T14:01:11Z

Thank you @ro0NL.

This PR was merged into the 2.7 branch. Discussion ---------- [DI] Remove irrelevant comment from container | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  Spotted in #22811 Commits ------- 595a225 [DI] Remove irrelevant comment from container

carsonbot added Status: Needs Review DependencyInjection BC Break labels May 20, 2017

nicolas-grekas modified the milestone: 4.0 May 21, 2017

nicolas-grekas reviewed May 21, 2017

View reviewed changes

ro0NL commented May 21, 2017

View reviewed changes

Tobion reviewed May 26, 2017

View reviewed changes

ro0NL commented May 26, 2017

View reviewed changes

ro0NL mentioned this pull request Jun 26, 2017

[DI] Remove an unused property #23300

Merged

stof requested changes Jun 26, 2017

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jul 6, 2017

carsonbot added Status: Needs Review and removed Status: Needs Work labels Jul 7, 2017

Tobion reviewed Jul 7, 2017

View reviewed changes

[DI] Remove deprecated case insensitive service ids

c8ff0f2

ro0NL mentioned this pull request Jul 8, 2017

[DI] Remove irrelevant comment from container #23452

Merged

Update Container.php

1034f40

Tobion approved these changes Jul 8, 2017

View reviewed changes

nicolas-grekas closed this in a55cbf8 Jul 11, 2017

ro0NL deleted the di/service-ids-4.0 branch July 12, 2017 11:22

fabpot mentioned this pull request Oct 19, 2017

Release v4.0.0-BETA1 #24612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DI] Remove deprecated case insensitive service ids #22811

[DI] Remove deprecated case insensitive service ids #22811

ro0NL commented May 20, 2017 •

edited

nicolas-grekas May 21, 2017

nicolas-grekas commented May 21, 2017

ro0NL commented May 21, 2017 •

edited

ro0NL May 21, 2017 •

edited

Tobion May 26, 2017

Tobion May 26, 2017

ro0NL commented May 21, 2017

nicolas-grekas commented May 22, 2017

Tobion May 26, 2017

Tobion May 26, 2017

ro0NL May 26, 2017

stof Jun 26, 2017

ro0NL commented May 26, 2017 •

edited

GuilhemN commented May 26, 2017 •

edited

ro0NL commented May 29, 2017

stof Jun 26, 2017

stof Jun 26, 2017

fabpot commented Jul 6, 2017

ro0NL commented Jul 6, 2017

ro0NL commented Jul 7, 2017

Tobion Jul 7, 2017

GuilhemN Jul 7, 2017 •

edited

ro0NL Jul 8, 2017

Tobion Jul 7, 2017

ro0NL Jul 8, 2017

Tobion Jul 7, 2017

ro0NL Jul 8, 2017 •

edited

nicolas-grekas commented Jul 11, 2017

		@@ -28,7 +28,7 @@
		*
		* Parameter and service keys are case insensitive.

[DI] Remove deprecated case insensitive service ids #22811

[DI] Remove deprecated case insensitive service ids #22811

Conversation

ro0NL commented May 20, 2017 • edited

Choose a reason for hiding this comment

nicolas-grekas commented May 21, 2017

ro0NL commented May 21, 2017 • edited

ro0NL May 21, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL commented May 21, 2017

nicolas-grekas commented May 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL commented May 26, 2017 • edited

GuilhemN commented May 26, 2017 • edited

ro0NL commented May 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabpot commented Jul 6, 2017

ro0NL commented Jul 6, 2017

ro0NL commented Jul 7, 2017

Choose a reason for hiding this comment

GuilhemN Jul 7, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL Jul 8, 2017 • edited

Choose a reason for hiding this comment

nicolas-grekas commented Jul 11, 2017

ro0NL commented May 20, 2017 •

edited

ro0NL commented May 21, 2017 •

edited

ro0NL May 21, 2017 •

edited

ro0NL commented May 26, 2017 •

edited

GuilhemN commented May 26, 2017 •

edited

GuilhemN Jul 7, 2017 •

edited

ro0NL Jul 8, 2017 •

edited