New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the simple exception pages match the new style #22838

Closed
wants to merge 2 commits into
base: 3.3
from

Conversation

Projects
None yet
6 participants
@javiereguiluz
Member

javiereguiluz commented May 21, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22631
License MIT
Doc PR -

If you create an application with Symfony Flex and don't install the TwigBundle explicitly, you see the exception pages like this:

before

This PR updates that page to match the style of the rest of exceptions:

after

For comparison, this is how the full exception page looks:

full-exception


Should I add the small black top header with the Symfony logo too?

@javiereguiluz javiereguiluz added the Debug label May 21, 2017

@xabbuh xabbuh added this to the 3.3 milestone May 22, 2017

@nicolas-grekas

👍

@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh May 24, 2017

Member

Should I add the small black top header with the Symfony logo too?

If that's not too much work, I'd say yes. :)

Member

xabbuh commented May 24, 2017

Should I add the small black top header with the Symfony logo too?

If that's not too much work, I'd say yes. :)

@deflock

This comment has been minimized.

Show comment
Hide comment
@deflock

deflock May 27, 2017

Black header with logo may confuse when Debug is used as standalone component.
Will this be merged until 3.3 release?

deflock commented May 27, 2017

Black header with logo may confuse when Debug is used as standalone component.
Will this be merged until 3.3 release?

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 27, 2017

Member

@javiereguiluz Last call for 3.3 :)

Member

fabpot commented May 27, 2017

@javiereguiluz Last call for 3.3 :)

@javiereguiluz

This comment has been minimized.

Show comment
Hide comment
@javiereguiluz

javiereguiluz May 27, 2017

Member

If we don't want to add the black header ... this should be finished. @deflock has a good point about not adding that header. I'm divided about that.

Member

javiereguiluz commented May 27, 2017

If we don't want to add the black header ... this should be finished. @deflock has a good point about not adding that header. I'm divided about that.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 27, 2017

Member

Thank you @javiereguiluz.

Member

fabpot commented May 27, 2017

Thank you @javiereguiluz.

fabpot added a commit that referenced this pull request May 27, 2017

feature #22838 Make the simple exception pages match the new style (j…
…aviereguiluz)

This PR was squashed before being merged into the 3.3 branch (closes #22838).

Discussion
----------

Make the simple exception pages match the new style

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22631
| License       | MIT
| Doc PR        | -

If you create an application with Symfony Flex and don't install the TwigBundle explicitly, you see the exception pages like this:

![before](https://cloud.githubusercontent.com/assets/73419/26286531/3737f41c-3e68-11e7-8f1f-d9454bbc81f2.png)

This PR updates that page to match the style of the rest of exceptions:

![after](https://cloud.githubusercontent.com/assets/73419/26286534/488a2e4c-3e68-11e7-9d9e-8af8a478ff44.png)

For comparison, this is how the full exception page looks:

![full-exception](https://cloud.githubusercontent.com/assets/73419/26286535/56d69f26-3e68-11e7-8068-8334f045a63d.png)

---

Should I add the small black top header with the Symfony logo too?

Commits
-------

bab4b9c Make the simple exception pages match the new style

@fabpot fabpot closed this May 27, 2017

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

fabpot added a commit to silexphp/Silex that referenced this pull request Jun 2, 2017

minor #1528 Fix exception hander test (chihiro-adachi)
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1528).

Discussion
----------

Fix exception hander test

In symfony 3.3.0, the markup of the error wording has been changed.

symfony/symfony#22838

3.2.x
`<h1>$title</h1>`

3.3.0
`<h1 class="break-long-words exception-message">$title</h1>`

Therefore, in the symfony 3.3.0 environment, ExceptionHandlerTest fails.

```
1) Silex \ Tests \ ExceptionHandlerTest :: testExceptionHandlerExceptionNoDebug
Failed asserting that '<! DOCTYPE html>

...

Contains "<h1> Whoops, looks like something went wrong. </h1>".
```

https://github.com/symfony/symfony/pull/22838/files#diff-5a9ac37e71d14aa261fe6f68848a6277L42

I deleted `<h1>` by referring to it.

Commits
-------

69e2771 Fix exception hander test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment