Make the simple exception pages match the new style #22838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If that's not too much work, I'd say yes. :) |
|
Black header with logo may confuse when Debug is used as standalone component. |
|
@javiereguiluz Last call for 3.3 :) |
|
If we don't want to add the black header ... this should be finished. @deflock has a good point about not adding that header. I'm divided about that. |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
May 27, 2017
…aviereguiluz) This PR was squashed before being merged into the 3.3 branch (closes #22838). Discussion ---------- Make the simple exception pages match the new style | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22631 | License | MIT | Doc PR | - If you create an application with Symfony Flex and don't install the TwigBundle explicitly, you see the exception pages like this:  This PR updates that page to match the style of the rest of exceptions:  For comparison, this is how the full exception page looks:  --- Should I add the small black top header with the Symfony logo too? Commits ------- bab4b9c Make the simple exception pages match the new style
Merged
fabpot
added a commit
to silexphp/Silex
that referenced
this pull request
Jun 2, 2017
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1528). Discussion ---------- Fix exception hander test In symfony 3.3.0, the markup of the error wording has been changed. symfony/symfony#22838 3.2.x `<h1>$title</h1>` 3.3.0 `<h1 class="break-long-words exception-message">$title</h1>` Therefore, in the symfony 3.3.0 environment, ExceptionHandlerTest fails. ``` 1) Silex \ Tests \ ExceptionHandlerTest :: testExceptionHandlerExceptionNoDebug Failed asserting that '<! DOCTYPE html> ... Contains "<h1> Whoops, looks like something went wrong. </h1>". ``` https://github.com/symfony/symfony/pull/22838/files#diff-5a9ac37e71d14aa261fe6f68848a6277L42 I deleted `<h1>` by referring to it. Commits ------- 69e2771 Fix exception hander test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create an application with Symfony Flex and don't install the TwigBundle explicitly, you see the exception pages like this:
This PR updates that page to match the style of the rest of exceptions:
For comparison, this is how the full exception page looks:
Should I add the small black top header with the Symfony logo too?