respect the API in FirewallContext map #23287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Jun 24, 2017
| $firewallContext = $this->getMockBuilder(FirewallContext::class)->disableOriginalConstructor()->getMock(); | ||
| $firewallContext->expects($this->once())->method('getConfig')->willReturn('CONFIG'); | ||
| $firewallContext->expects($this->once())->method('getListeners')->willReturn('LISTENERS'); | ||
| $firewallContext->expects($this->once())->method('getExceptionListener')->willReturn('EXCEPTION LISTENER'); | ||
| $firewallContext->expects($this->once())->method('getListeners')->willReturn(array('LISTENERS')); |
There was a problem hiding this comment.
To fulfil the contract array('LISTENERS') should be an array of ListenerInterface instances
chalasr
reviewed
Jun 24, 2017
| @@ -57,10 +58,11 @@ public function testGetListeners() | |||
| { | |||
| $request = new Request(); | |||
|
|
|||
| $exceptionListener = $this->getMockBuilder(ExceptionListener::class)->disableOriginalConstructor()->getMock(); | |||
| $firewallContext = $this->getMockBuilder(FirewallContext::class)->disableOriginalConstructor()->getMock(); | |||
| $firewallContext->expects($this->once())->method('getConfig')->willReturn('CONFIG'); | |||
There was a problem hiding this comment.
same here, should return a FirewallConfig instance
chalasr
approved these changes
Jun 24, 2017
When being merged up, this will make the SecurityBundle tests on master green again.
xabbuh
force-pushed
the
firewall-map-tests
branch
from
a03f25d
to
ddf4368
Compare
fabpot
approved these changes
Jun 24, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 24, 2017
This PR was merged into the 3.3 branch. Discussion ---------- respect the API in FirewallContext map | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When being merged up, this will make the SecurityBundle tests on master green again. Commits ------- ddf4368 respect the API in FirewallContext map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When being merged up, this will make the SecurityBundle tests on master
green again.