[Routing] Add matched and default parameters to redirect responses #23440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
|
deps=high failure will be fixed when 3.4 will be merged into master |
Tobion
reviewed
Jul 10, 2017
| } else { | ||
| $code .= sprintf(" return array('_route' => '%s');\n", $name); | ||
| $code = substr_replace($code, 'return', $retOffset + 12, 6); |
There was a problem hiding this comment.
this $retOffset is hard to understand. please add a comment what this line does
There was a problem hiding this comment.
thanks, addressed
nicolas-grekas
force-pushed
the
bugfix-add-matched-params-to-redirect
branch
from
855206b
to
e39b404
Compare
Tobion
approved these changes
Jul 10, 2017
nicolas-grekas
force-pushed
the
bugfix-add-matched-params-to-redirect
branch
from
e39b404
to
4c1fdd4
Compare
|
Thank you @artursvonda @Tobion |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2017
…ct responses (artursvonda, Tobion) This PR was merged into the 3.4 branch. Discussion ---------- [Routing] Add matched and default parameters to redirect responses | Q | A | | --- | --- | | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | #18012, #19037 | | License | MIT | | Doc PR | | Finished #18012 and #19037 Commits ------- 4c1fdd4 [Routing] also add matched params for redirect due to trailing slash dc3f7a9 [Routing] Add matched and default parameters to redirect responses
nicolas-grekas
added a commit
that referenced
this pull request
Jul 12, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Fix tests | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Related to the changes introduced in #23440. Commits ------- 2e0c6bc [FrameworkBundle] Fix tests
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished #18012 and #19037