Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DebugBundle] Added min_depth to Configuration #23550

Merged
merged 1 commit into from
Jul 19, 2017
Merged

[DebugBundle] Added min_depth to Configuration #23550

merged 1 commit into from
Jul 19, 2017

Conversation

james-johnston-thumbtack
Copy link
Contributor

This enables calling the recently-added setMinDepth function on VarCloner.

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR symfony/symfony-docs#8185

@james-johnston-thumbtack
[DebugBundle] Added min_depth to Configuration
30cd70d 
This enables calling the recently-added setMinDepth function on
VarCloner.
@james-johnston-thumbtack
Copy link
Contributor Author

It seems Travis failed due to unrelated breakage on the 3.4 branch. I can't see how it's related to this PR. This unrelated PR failed with the same errors: #23548

1) Symfony\Bridge\Twig\Tests\Node\FormThemeTest::testCompile
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->setTheme(($context["form"] ?? null), array(0 => "tpl1", 1 => "tpl2"));'
+'$this->env->getRuntime("Symfony\\Bridge\\Twig\\Form\\TwigRenderer")->setTheme(($context["form"] ?? null), array(0 => "tpl1", 1 => "tpl2"));'
/home/travis/build/symfony/symfony/src/Symfony/Bridge/Twig/Tests/Node/FormThemeTest.php:58
/home/travis/build/symfony/symfony/.phpunit/phpunit-6.0/phpunit:5
/home/travis/build/symfony/symfony/vendor/symfony/phpunit-bridge/bin/simple-phpunit:192

nicolas-grekas
nicolas-grekas approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(failure unrelated)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 19, 2017
@nicolas-grekas
Copy link
Member

Thank you @james-johnston-thumbtack.

@nicolas-grekas nicolas-grekas merged commit 30cd70d into symfony:3.4 Jul 19, 2017
nicolas-grekas added a commit that referenced this pull request Jul 19, 2017
@nicolas-grekas
feature #23550 [DebugBundle] Added min_depth to Configuration (james-…
719465c 
…johnston-thumbtack)

This PR was merged into the 3.4 branch.

Discussion
----------

[DebugBundle] Added min_depth to Configuration

This enables calling the recently-added `setMinDepth` function on `VarCloner`.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | symfony/symfony-docs#8185

Commits
-------

30cd70d [DebugBundle] Added min_depth to Configuration
@james-johnston-thumbtack james-johnston-thumbtack deleted the DebugBundle-setMinDepth branch July 19, 2017 20:25
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DebugBundle Feature Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@james-johnston-thumbtack @nicolas-grekas @carsonbot