[DI] Fix using private services in expressions #23654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
di-expression
branch
3 times, most recently
from
208bf05
to
68744e6
Compare
robfrawley
reviewed
Jul 24, 2017
| @@ -299,7 +299,7 @@ protected function getMethodCall1Service() | |||
|
|
|||
| $instance->setBar($this->get('foo')); | |||
| $instance->setBar(NULL); | |||
| $instance->setBar(($this->get("foo")->foo() . (($this->hasParameter("foo")) ? ($this->getParameter("foo")) : ("default")))); | |||
| $instance->setBar(($this->get('foo')->foo() . (($this->hasParameter("foo")) ? ($this->getParameter("foo")) : ("default")))); | |||
There was a problem hiding this comment.
You changed an instance of double quotes to single quotes on this line, but left three other instances untouched. Why not change them all to single quotes?
Never mind; I didn't notice this was a "compiled" file. I guess you would need to search out where else this is generated, which is likely not worth the effort.
There was a problem hiding this comment.
That's a minor, yet important side effect of the way this block of code is generated.
Will be even more visible in 3.3 where this will be something completely different.
nicolas-grekas
force-pushed
the
di-expression
branch
from
68744e6
to
9c08256
Compare
|
In fact, the remaining issue is now fixed in this very PR, as bug fix: private services used only in expressions are now considered when building the service dependency graph. |
nicolas-grekas
force-pushed
the
di-expression
branch
from
9c08256
to
f3da6cf
Compare
stof
approved these changes
Jul 25, 2017
chalasr
approved these changes
Jul 25, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Jul 26, 2017
…ekas) This PR was merged into the 3.2 branch. Discussion ---------- [DI] Fix using private services in expressions | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Since 3.2, fetching private services via `$container->get()` is deprecated. This makes it impossible to use a private service in an expression. Until this PR :) Commits ------- f3da6cf [DI] Fix using private services in expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.2, fetching private services via
$container->get()is deprecated.This makes it impossible to use a private service in an expression.
Until this PR :)