[Debug] Correctly detect methods not from the same vendor #23844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing I'm aware of |
|
Ok, thanks :) |
|
Thank you @GuilhemN. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 9, 2017
…(GuilhemN) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Correctly detect methods not from the same vendor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I just realized there were two issues in #23816: * when a class extended another class from the same vendor itself extending a class from another vendor containing deprecated methods, the deprecation wasn't triggered in case the first class extended a deprecated method from the last class because the parent from the same vendor was used for "the same vendor check". * As stated in #23816 (comment), ReflectionMethod::$class doesn't contain the right value when using a trait so if you extended a trait containing methods from another vendor you would have always get deprecations. I fixed this by comparing the method file to the filename of the class using the trait. @nicolas-grekas are you aware of any issue of `ReflectionMethod::getFilename()`? Commits ------- 08d352a [Debug] Correctly detect methods not from the same vendor
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Aug 23, 2017
…vendor (GuilhemN) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Correctly detect methods not from the same vendor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I just realized there were two issues in symfony#23816: * when a class extended another class from the same vendor itself extending a class from another vendor containing deprecated methods, the deprecation wasn't triggered in case the first class extended a deprecated method from the last class because the parent from the same vendor was used for "the same vendor check". * As stated in symfony#23816 (comment), ReflectionMethod::$class doesn't contain the right value when using a trait so if you extended a trait containing methods from another vendor you would have always get deprecations. I fixed this by comparing the method file to the filename of the class using the trait. @nicolas-grekas are you aware of any issue of `ReflectionMethod::getFilename()`? Commits ------- 08d352a [Debug] Correctly detect methods not from the same vendor
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Aug 23, 2017
…vendor (GuilhemN) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Correctly detect methods not from the same vendor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I just realized there were two issues in symfony#23816: * when a class extended another class from the same vendor itself extending a class from another vendor containing deprecated methods, the deprecation wasn't triggered in case the first class extended a deprecated method from the last class because the parent from the same vendor was used for "the same vendor check". * As stated in symfony#23816 (comment), ReflectionMethod::$class doesn't contain the right value when using a trait so if you extended a trait containing methods from another vendor you would have always get deprecations. I fixed this by comparing the method file to the filename of the class using the trait. @nicolas-grekas are you aware of any issue of `ReflectionMethod::getFilename()`? Commits ------- 08d352a [Debug] Correctly detect methods not from the same vendor
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Aug 23, 2017
…vendor (GuilhemN) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Correctly detect methods not from the same vendor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I just realized there were two issues in symfony#23816: * when a class extended another class from the same vendor itself extending a class from another vendor containing deprecated methods, the deprecation wasn't triggered in case the first class extended a deprecated method from the last class because the parent from the same vendor was used for "the same vendor check". * As stated in symfony#23816 (comment), ReflectionMethod::$class doesn't contain the right value when using a trait so if you extended a trait containing methods from another vendor you would have always get deprecations. I fixed this by comparing the method file to the filename of the class using the trait. @nicolas-grekas are you aware of any issue of `ReflectionMethod::getFilename()`? Commits ------- 08d352a [Debug] Correctly detect methods not from the same vendor
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Aug 23, 2017
…vendor (GuilhemN) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Correctly detect methods not from the same vendor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I just realized there were two issues in symfony#23816: * when a class extended another class from the same vendor itself extending a class from another vendor containing deprecated methods, the deprecation wasn't triggered in case the first class extended a deprecated method from the last class because the parent from the same vendor was used for "the same vendor check". * As stated in symfony#23816 (comment), ReflectionMethod::$class doesn't contain the right value when using a trait so if you extended a trait containing methods from another vendor you would have always get deprecations. I fixed this by comparing the method file to the filename of the class using the trait. @nicolas-grekas are you aware of any issue of `ReflectionMethod::getFilename()`? Commits ------- 08d352a [Debug] Correctly detect methods not from the same vendor
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Aug 23, 2017
…vendor (GuilhemN) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Correctly detect methods not from the same vendor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I just realized there were two issues in symfony#23816: * when a class extended another class from the same vendor itself extending a class from another vendor containing deprecated methods, the deprecation wasn't triggered in case the first class extended a deprecated method from the last class because the parent from the same vendor was used for "the same vendor check". * As stated in symfony#23816 (comment), ReflectionMethod::$class doesn't contain the right value when using a trait so if you extended a trait containing methods from another vendor you would have always get deprecations. I fixed this by comparing the method file to the filename of the class using the trait. @nicolas-grekas are you aware of any issue of `ReflectionMethod::getFilename()`? Commits ------- 08d352a [Debug] Correctly detect methods not from the same vendor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized there were two issues in #23816:
when a class extended another class from the same vendor itself extending a class from another vendor containing deprecated methods, the deprecation wasn't triggered in case the first class extended a deprecated method from the last class because the parent from the same vendor was used for "the same vendor check".
As stated in [Debug] Detect internal and deprecated methods #23816 (comment), ReflectionMethod::$class doesn't contain the right value when using a trait so if you extended a trait containing methods from another vendor you would have always get deprecations. I fixed this by comparing the method file to the filename of the class using the trait.
@nicolas-grekas are you aware of any issue of
ReflectionMethod::getFilename()?