[Dotenv] Get env using $_SERVER to work with fastcgi_param and workaround thread safety issues #23949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Aug 22, 2017
nicolas-grekas
force-pushed
the
no-getenv
branch
from
091a67b
to
e72e75c
Compare
…ound thread safety issues
nicolas-grekas
force-pushed
the
no-getenv
branch
from
e72e75c
to
f76e420
Compare
nicolas-grekas
commented
Aug 22, 2017
| continue; | ||
| } | ||
|
|
||
| putenv("$name=$value"); | ||
| $_ENV[$name] = $value; | ||
| $_SERVER[$name] = $value; | ||
| if ($notHttpName) { |
There was a problem hiding this comment.
with this, env vars that start with HTTP_* do not populate $_SERVER anymore.
this is to mitigate security issues with $_SERVER mixing several sources (env+http headers+etc).
Simperfit
approved these changes
Aug 22, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 22, 2017
… and workaround thread safety issues (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Dotenv] Get env using $_SERVER to work with fastcgi_param and workaround thread safety issues | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23502 | License | MIT | Doc PR | - `getenv()` is not thread safe, and doesn't work with `fastcgi_param`, see links in linked issue. Commits ------- f76e420 [Dotenv] Get env using $_SERVER to work with fastcgi_param and workaround thread safety issues
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getenv()is not thread safe, and doesn't work withfastcgi_param, see links in linked issue.