[Security] Fix exception when use_referer option is true and referer is not set or empty #24101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
linniksa
commented
Sep 5, 2017
linniksa
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
chalasr
reviewed
Sep 6, 2017
| if (false !== $pos = strpos($targetUrl, '?')) { | ||
| $targetUrl = substr($targetUrl, 0, $pos); | ||
| } | ||
| if ($targetUrl !== $this->httpUtils->generateUri($request, $this->options['login_path'])) { | ||
| if (!empty($targetUrl) && $targetUrl !== $this->httpUtils->generateUri($request, $this->options['login_path'])) { |
There was a problem hiding this comment.
I would use $targetUrl instead of !empty().
…is not set or empty
chalasr
approved these changes
Sep 7, 2017
fabpot
approved these changes
Sep 7, 2017
|
Thank you @linniksa. |
fabpot
added a commit
that referenced
this pull request
Sep 7, 2017
…nd referer is not set or empty (linniksa) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #24101). Discussion ---------- [Security] Fix exception when use_referer option is true and referer is not set or empty | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- a29e069 [Security] Fix exception when use_referer option is true and referer is not set or empty
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.