Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBundle] Break long lines in exceptions #24255

Merged

Conversation

kevin-verschaeve
Copy link
Contributor

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Break long lines in exception to stay in screen

Before:
exception_before

After:
exception_after

@javiereguiluz
Copy link
Member

@kevin-verschaeve nice catch! Thanks for fixing it.

However, to make this work in any browser, could you please add instead the .break-long-words CSS class to the appropriate HTML element? We define that class in this very same CSS file as follows (it's ugly ... but it's the only style that worked right in every browser):

.break-long-words { -ms-word-break: break-all; word-break: break-all; word-break: break-word; -webkit-hyphens: auto; -moz-hyphens: auto; hyphens: auto; }

@kevin-verschaeve
Copy link
Contributor Author

@javiereguiluz Thanks, I have updated the PR.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Sep 20, 2017
@javiereguiluz
Copy link
Member

Thanks for fixing this bug @kevin-verschaeve.

@javiereguiluz javiereguiluz merged commit 1db99f3 into symfony:3.3 Sep 21, 2017
javiereguiluz added a commit that referenced this pull request Sep 21, 2017
…eve)

This PR was merged into the 3.3 branch.

Discussion
----------

[TwigBundle] Break long lines in exceptions

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Break long lines in exception to stay in screen

Before:
![exception_before](https://user-images.githubusercontent.com/2345927/30586794-63b35b44-9d31-11e7-90ce-507af56934d0.png)

After:
![exception_after](https://user-images.githubusercontent.com/2345927/30586801-691c2548-9d31-11e7-9af4-54c01b4cc400.png)

Commits
-------

1db99f3 [TwigBundle] Break long lines in exceptions
@fabpot fabpot mentioned this pull request Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants