New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bridge\Twig] Lazy-load deps #24863

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 7, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Spotted while benching a HelloWorld and comparing v3.3 to v4.0.
At this micro-bench level, even registering one more twig extension makes a difference (here, it's TranslationExtension, after #24358)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 7, 2017

@nicolas-grekas nicolas-grekas changed the base branch from master to 3.4 Nov 7, 2017

@fabpot

fabpot approved these changes Nov 7, 2017

3.4?

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Nov 7, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented Nov 7, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 3fc766f into symfony:3.4 Nov 7, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Nov 7, 2017

minor #24863 [Bridge\Twig] Lazy-load deps (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Bridge\Twig] Lazy-load deps

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Spotted while benching a HelloWorld and comparing v3.3 to v4.0.
At this micro-bench level, even registering one more twig extension makes a difference (here, it's `TranslationExtension`, after #24358)

Commits
-------

3fc766f [Bridge\Twig] Lazy-load deps

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:lazy-load branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment