[Console] Fix traversable autocomplete values #24929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Nov 11, 2017
| @@ -134,7 +134,7 @@ public function doAsk(OutputInterface $output, Question $question) | |||
| $ret = trim($ret); | |||
| } | |||
| } else { | |||
| $ret = trim($this->autocomplete($output, $question, $inputStream)); | |||
| $ret = trim($this->autocomplete($output, $question, $inputStream, is_array($autocomplete) ? $autocomplete : iterator_to_array($autocomplete, false))); | |||
There was a problem hiding this comment.
passing false to iterator_to_array fixes
1) Symfony\Component\Console\Tests\Helper\QuestionHelperTest::testTraversableAutocomplete
Undefined offset: 3
src/Symfony/Component/Console/Helper/QuestionHelper.php:294
in case of assoc array keys (which we dont really care about)
of course using iterator_to_array fixes the offset access in the first place ;)
fabpot
approved these changes
Nov 12, 2017
nicolas-grekas
approved these changes
Nov 12, 2017
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Nov 12, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix traversable autocomplete values | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> `Question::setAutocompleterValues` implies passing a `\Traversable` value is allowed, yet it doesnt work :) It also restricts the traversable to be countable, which is not really needed (blocking pure API / iterable type as of 4.0). Commits ------- 965b5b5 [Console] Fix traversable autocomplete values
This was referenced Nov 12, 2017
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question::setAutocompleterValuesimplies passing a\Traversablevalue is allowed, yet it doesnt work :) It also restricts the traversable to be countable, which is not really needed (blocking pure API / iterable type as of 4.0).