[MonologBridge][WebServerBundle] Add suggestions for using the log server #25026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidmaid
force-pushed
the
fix-log-server
branch
from
d76b3ee
to
407d337
Compare
|
Related; should we patch |
nicolas-grekas
approved these changes
Nov 19, 2017
|
I'm personally 👎 on adding more |
maidmaid
force-pushed
the
fix-log-server
branch
from
407d337
to
aca0ddd
Compare
|
ping @fabpot still not sold? I'm still +1 on my side :) |
|
@nicolas-grekas Let's say I'm just +0 on this. |
|
Merging then, especially since suggestions are not displayed in Flex era. |
|
Thank you @maidmaid. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2017
…ng the log server (maidmaid) This PR was merged into the 3.3 branch. Discussion ---------- [MonologBridge][WebServerBundle] Add suggestions for using the log server | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / If you want launch `server:log`, you need the monolog bridge and the VarDumper. Optionally, you need EL if you want use `server:log --filter`. Commits ------- aca0ddd Add suggestions
nicolas-grekas
added a commit
that referenced
this pull request
Jan 3, 2018
…ists (kbond) This PR was merged into the 3.3 branch. Discussion ---------- [WebServerBundle] use interface_exists instead of class_exists | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This bug was introduced in #25026 Commits ------- dc3a94e use interface_exists instead of class_exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want launch
server:log, you need the monolog bridge and the VarDumper. Optionally, you need EL if you want useserver:log --filter.