Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Dont rely on putenv(), it fails on ZTS PHP #25417

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Dec 10, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24924
License MIT
Doc PR -

putenv() is not thread safe, but ZTS is PHP defaults on Windows.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:proc-getenv branch from 5624a89 to ef632ec Dec 10, 2017

@fabpot

fabpot approved these changes Dec 11, 2017

@fabpot

This comment has been minimized.

Copy link
Member

commented Dec 11, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit ef632ec into symfony:3.3 Dec 11, 2017

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Dec 11, 2017

bug #25417 [Process] Dont rely on putenv(), it fails on ZTS PHP (nico…
…las-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[Process] Dont rely on putenv(), it fails on ZTS PHP

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24924
| License       | MIT
| Doc PR        | -

`putenv()` is not thread safe, but ZTS is PHP defaults on Windows.

Commits
-------

ef632ec [Process] Dont rely on putenv(), it fails on ZTS PHP

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:proc-getenv branch Dec 12, 2017

This was referenced Dec 15, 2017

@fabpot fabpot referenced this pull request Jan 5, 2018

Merged

Release v3.3.15 #25690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.