Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Fix tests #25463

Merged
merged 1 commit into from
Dec 12, 2017
Merged

[HttpFoundation] Fix tests #25463

merged 1 commit into from
Dec 12, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Dec 12, 2017

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? not yet
Fixed tickets n/a
License MIT
Doc PR n/a

Remains filesystem ones due to #25420, going to have a look in this PR in the next hour if nobody does before.

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit ef6adb8 into symfony:3.3 Dec 12, 2017
nicolas-grekas added a commit that referenced this pull request Dec 12, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

[HttpFoundation] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | not yet
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Remains filesystem ones due to #25420, going to have a look in this PR in the next hour if nobody does before.

Commits
-------

ef6adb8 Fix tests
@chalasr chalasr deleted the fix_tests branch December 12, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants