[2.7] Fix issues found by PHPStan #25558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Dec 20, 2017
| @@ -1103,8 +1102,7 @@ public function testLoaderCaching() | |||
| $repo = $this->em->getRepository(self::SINGLE_IDENT_CLASS); | |||
|
|
|||
| $entityType = new EntityType( | |||
| $this->emRegistry, | |||
| PropertyAccess::createPropertyAccessor() | |||
| $this->emRegistry | |||
nicolas-grekas
force-pushed
the
phpstan27
branch
from
94b797b
to
afa1f14
Compare
ro0NL
approved these changes
Dec 20, 2017
javiereguiluz
approved these changes
Dec 20, 2017
|
Thank you @dkarlovi. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 20, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [2.7] Fix issues found by PHPStan | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is the subpart of #25536 that applies on 2.7. ping @dkarlovi FYI. Commits ------- afa1f14 [2.7] Fix issues found by PHPStan
|
Now merged up to master. |
|
Nice. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the subpart of #25536 that applies on 2.7.
ping @dkarlovi FYI.