Improve assertions #25908
Merged
Improve assertions #25908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jan 23, 2018
dunglas
approved these changes
Jan 23, 2018
javiereguiluz
approved these changes
Jan 24, 2018
Simperfit
approved these changes
Jan 24, 2018
|
Thank you @carusogabriel. |
fabpot
added a commit
that referenced
this pull request
Jan 29, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Improve assertions | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Following #25420 in `2.8` branch. Commits ------- 4683f6d Improve assertions
SpacePossum
reviewed
Feb 1, 2018
| @@ -84,9 +84,9 @@ public function testCsrfAliases() | |||
| $processor = new Processor(); | |||
| $configuration = new MainConfiguration(array(), array()); | |||
| $processedConfig = $processor->processConfiguration($configuration, array($config)); | |||
| $this->assertTrue(isset($processedConfig['firewalls']['stub']['logout']['csrf_token_generator'])); | |||
| $this->assertArrayHasKey('csrf_token_generator', $processedConfig['firewalls']['stub']['logout']); | |||
There was a problem hiding this comment.
this change is not better as let;
$processedConfig['firewalls']['stub']['logout']['csrf_token_generator'] = null
then in the old situation the test would fail, in the new one it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #25420 in
2.8branch.