Disable CSP header on exception pages only in debug #25933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same condition is used by default TwigBridge ExceptionController to evaluate if styled exception page is supposed to be shown.
carsonbot
added
Status: Needs Review
Bug
Status: Reviewed
and removed
Status: Needs Review
labels
fabpot
approved these changes
Jan 26, 2018
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Jan 26, 2018
…lucky) This PR was merged into the 2.7 branch. Discussion ---------- Disable CSP header on exception pages only in debug | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24772 | License | MIT | Doc PR | Based on a feedback we received, there are situations on production when it's desired to have CSP header in place even if exception occurred. This uses now same condition that is used by ExceptionController in TwigBridge to evaluate if styled exception template is going to be shown, minus `showException` request attribute which don't make sense in this context, because it's used by PreviewController only and in such case this listener isn't triggered. Overriding CSP header via HTML meta tag unfortunately, but not surprisingly, doesn't work. Commits ------- b77538c Disable CSP header on exception pages only in debug
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
That's logic: the meta tag can add a new header, not replace the HTTP headers. And the behavior of browsers when receiving multiple CSP headers is to apply all policies (making a AND between them). So a new header cannot disable the other ones. |
stof
reviewed
Jan 29, 2018
| @@ -32,11 +32,13 @@ class ExceptionListener implements EventSubscriberInterface | |||
| { | |||
| protected $controller; | |||
| protected $logger; | |||
| protected $debug; | |||
There was a problem hiding this comment.
should have been private (too bad that I see it just after the release is done)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a feedback we received, there are situations on production when it's desired to have CSP header in place even if exception occurred.
This uses now same condition that is used by ExceptionController in TwigBridge to evaluate if styled exception template is going to be shown, minus
showExceptionrequest attribute which don't make sense in this context, because it's used by PreviewController only and in such case this listener isn't triggered.Overriding CSP header via HTML meta tag unfortunately, but not surprisingly, doesn't work.