[Security][Validator] Add translations for Tagalog #26130
Conversation
ergiegonzaga
commented
Feb 10, 2018
•
ergiegonzaga
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | #... |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
|
Why failed? |
|
@ergiegonzaga there is a minor problem in one of the XML files. This is how you can solve it:
|
|
Ahh okay sir , thanks |
|
Sir? why does it failed again this time? what's the problem? |
|
@ergiegonzaga there are some problems which are unrelated to your changes ... but there's still a super minor problem with your pull request. The last line of the |
|
okay sir i'll look at it now. |
|
Sir, why does it failed again? I already removed the last (+) sign. |
|
Hi! can someone help me on why does my pull request fails ? |
|
Hi! can someone help me on why does my pull request fails ? |
| </trans-unit> | ||
| <trans-unit id="55"> | ||
| <source>This collection should contain {{ limit }} element or less.|This collection should contain {{ limit }} elements or less.</source> | ||
| <target>Ang koleksyon na ito ay dapat magkaroon ng {{ limit }} elemento o maliit pa.|Ang koleksyon na ito ay dapat magkaroon ng {{ limit }} mga elemento o maliit pa.<</target> |
There was a problem hiding this comment.
@ergiegonzaga remove extra < from <</target>
There was a problem hiding this comment.
ahh, thanks sir, I did't really see that one.
|
Someone help me please with the error on my pull request.. |
nicolas-grekas
force-pushed
the
master
branch
2 times, most recently
from
d82ea36
to
2fb88e5
Compare
|
@ergiegonzaga good news, I rebased and squashed your PR on latest master (using the |
nicolas-grekas
changed the title
|
@nicolas-grekas Translations should always be merged in the lowest maintained branch (2.7 right now) even if some translations don't exist in 2.7. |
nicolas-grekas
force-pushed
the
master
branch
from
2fb88e5
to
120c39b
Compare
| <trans-unit id="7"> | ||
| <source>Invalid CSRF token.</source> | ||
| <target>Hindi balidong mga token ng CSRF.</target> | ||
| </trans-unit> |
There was a problem hiding this comment.
number 8 is missing https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Security/Core/Resources/translations/security.en.xlf#L33 , required for 2.7
There was a problem hiding this comment.
Sir, I already added the missing trans-unit #8 ...
Added trans #8
Updated security.tl.xlf
|
Hi sir,I already updated the security.tl.xlf and added trans #8 . |
|
sir? why does the (continuous-integration/appveyor/pr ) failed ? |
|
Please someone, help me with the error.. |
|
@ergiegonzaga looking at other pending PRs, this failure seems not to be related to your changes so you shouldn't be worried. |
|
aww okay sir, ill just wait for the project owner to review my pull request.. |
|
You did great! Thank you @ergiegonzaga. |
…egonzaga) This PR was submitted for the master branch but it was squashed and merged into the 2.7 branch instead (closes #26130). Discussion ---------- [Security][Validator] Add translations for Tagalog | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? |no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? |no | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Replace this comment by a description of what your PR is solving. --> Commits ------- 60abeca [Security][Validator] Add translations for Tagalog
|
Thank you sir, what other files I could translate into tagalog sir? |
|
There are some more translations under |
