[Security] Add missing use for RoleInterface #26286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if necessary to create a new PR, but there is the same issue with symfony 4.0 but this time it is the |
|
This can probably be merged up until 3.4. For 4.0+, a second PR has to be created to change it into |
|
by the way, we merged a similar PR before for the |
|
I don't understand why CI was failed ? Anyone can explain to me please ? |
tony-tran
changed the title
|
Don't worry the CI failures seems not related to the current changes. It will be fixed. |
chalasr
approved these changes
Feb 23, 2018
|
Good catch, thanks for contributing to Symfony @tony-tran |
chalasr
added a commit
that referenced
this pull request
Feb 23, 2018
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #26286). Discussion ---------- [Security] Add missing use for RoleInterface | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Just a missing `use ...\RoleInterface` in the `UsernamePasswordToken` since 3.3. Commits ------- 05359f3 Add missing use for RoleInterface
chalasr
added a commit
that referenced
this pull request
Feb 23, 2018
This PR was merged into the 4.0 branch. Discussion ---------- [Security] Add missing use of Role | Q | A | ------------- | --- | Branch? | 4.0 to master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Same as [here](#26286) but this time for 4.0 Commits ------- 3cfe7d0 Add missing use of Role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a missing
use ...\RoleInterfacein theUsernamePasswordTokensince 3.3.