Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfilerBundle] Fixed validator/dump trace CSS #27341

Merged
merged 1 commit into from
May 22, 2018
Merged

[WebProfilerBundle] Fixed validator/dump trace CSS #27341

merged 1 commit into from
May 22, 2018

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented May 22, 2018 •
edited
Loading

Q A
Branch? 3.4
Bug fix? yes (Visual)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Before
validator_profiler_before

After
validator_after

@ogizanagi
Copy link
Member

#collector-content .sf-dump .trace would need the same I guess

@yceruto yceruto changed the title [WebProfilerBundle] Fixed validator trace CSS [WebProfilerBundle] Fixed validator/dump trace CSS May 22, 2018
@yceruto
Copy link
Member Author

yceruto commented May 22, 2018

@ogizanagi Indeed, thank you.

@ogizanagi
Copy link
Member

Thanks @yceruto.

@ogizanagi ogizanagi merged commit 6075292 into symfony:3.4 May 22, 2018
ogizanagi added a commit that referenced this pull request May 22, 2018
@ogizanagi
bug #27341 [WebProfilerBundle] Fixed validator/dump trace CSS (yceruto)
c2f15af 
This PR was merged into the 3.4 branch.

Discussion
----------

[WebProfilerBundle] Fixed validator/dump trace CSS

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes (Visual)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

**Before**
![validator_profiler_before](https://user-images.githubusercontent.com/2028198/40375748-77184ba0-5dba-11e8-8cb6-9a9acdadf34a.png)

**After**
![validator_after](https://user-images.githubusercontent.com/2028198/40375759-803f2046-5dba-11e8-9434-c3e4c6842d3a.png)

Commits
-------

6075292 Fixed content trace CSS in profiler
@yceruto yceruto deleted the validator_trace_code branch May 22, 2018 17:24
This was referenced May 25, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yceruto @ogizanagi @stof @carsonbot