New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Fixed validator/dump trace CSS #27341

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
4 participants
@yceruto
Contributor

yceruto commented May 22, 2018

Q A
Branch? 3.4
Bug fix? yes (Visual)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Before
validator_profiler_before

After
validator_after

@stof

stof approved these changes May 22, 2018

@ogizanagi

This comment has been minimized.

Member

ogizanagi commented May 22, 2018

#collector-content .sf-dump .trace would need the same I guess

@yceruto yceruto changed the title from [WebProfilerBundle] Fixed validator trace CSS to [WebProfilerBundle] Fixed validator/dump trace CSS May 22, 2018

@yceruto

This comment has been minimized.

Contributor

yceruto commented May 22, 2018

@ogizanagi Indeed, thank you.

@ogizanagi

This comment has been minimized.

Member

ogizanagi commented May 22, 2018

Thanks @yceruto.

@ogizanagi ogizanagi merged commit 6075292 into symfony:3.4 May 22, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

ogizanagi added a commit that referenced this pull request May 22, 2018

bug #27341 [WebProfilerBundle] Fixed validator/dump trace CSS (yceruto)
This PR was merged into the 3.4 branch.

Discussion
----------

[WebProfilerBundle] Fixed validator/dump trace CSS

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes (Visual)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

**Before**
![validator_profiler_before](https://user-images.githubusercontent.com/2028198/40375748-77184ba0-5dba-11e8-8cb6-9a9acdadf34a.png)

**After**
![validator_after](https://user-images.githubusercontent.com/2028198/40375759-803f2046-5dba-11e8-9434-c3e4c6842d3a.png)

Commits
-------

6075292 Fixed content trace CSS in profiler

@yceruto yceruto deleted the yceruto:validator_trace_code branch May 22, 2018

This was referenced May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment